Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Even Odd in P4 #2126

Merged
merged 3 commits into from
Oct 7, 2020
Merged

Added Even Odd in P4 #2126

merged 3 commits into from
Oct 7, 2020

Conversation

ecwolf
Copy link
Contributor

@ecwolf ecwolf commented Oct 4, 2020

  • I fixed Add Even Odd in P4 #2125

    This is a P4 Even Odd code:

    We defined a new packet header "operation", with.

    number = the 7 bits of the number
    v = bit 0 of the number will be used to define if it is even or odd
    flag = will be 0 if even, or 1 if odd

    Let us assume that the operation header is carried over Ethernet and uses
    the Ethertype 0x123 to indicate the presence of the header.

    When a packet arrives to the switch it is validated the header operation.
    Then it is verified the last bit of the number. Is odd if its last digit
    is 1; it is even if its last digit is 0. The result will be set in flag.

@ecwolf
Copy link
Contributor Author

ecwolf commented Oct 4, 2020

It was added a commit "Adding Roman Numeral Conversion in Bash" by mistake

@jrg94
Copy link
Member

jrg94 commented Oct 7, 2020

It looks like that file is still there.

@jrg94 jrg94 requested a review from a team October 7, 2020 03:25
@jrg94 jrg94 self-assigned this Oct 7, 2020
@jrg94 jrg94 added enhancement Any code that improves the repo even odd See: https://sampleprograms.io/projects/even-odd/ labels Oct 7, 2020
@jrg94 jrg94 added this to the 1,000 Code Snippets milestone Oct 7, 2020
@ecwolf
Copy link
Contributor Author

ecwolf commented Oct 7, 2020

@jrg94 now it is correct. Finally removed the wrong files.

jrg94
jrg94 approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@jrg94 jrg94 merged commit 89ba466 into TheRenegadeCoder:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrg94 jrg94 jrg94 approved these changes

Assignees

@jrg94 jrg94

Labels
enhancement Any code that improves the repo even odd See: https://sampleprograms.io/projects/even-odd/
Projects
Code Snippets
Archived in project
Milestone
1,000 Code Snippets
Development

Successfully merging this pull request may close these issues.

Add Even Odd in P4
2 participants
@ecwolf @jrg94