Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Hello World in Debug.exe #2132

Merged
merged 2 commits into from
Oct 8, 2020
Merged

Added Hello World in Debug.exe #2132

merged 2 commits into from
Oct 8, 2020

Conversation

SubhasmitaSw
Copy link
Contributor

@SubhasmitaSw SubhasmitaSw commented Oct 4, 2020

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.

Complete the Applicable Sections Below

Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.

Code Snippets

image size=400px

  • I named the pull request using Added/Updated <Sample Program> in <Language> format

  • I created/updated the language README

    • I added the sample program name to the README
    • I added fun facts (i.e. debut developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

Testing

  • I named the pull request using Added/Updated <Language>/<Project> Testing format
  • I followed the testinfo template, if applicable

Notes

Feel free to describe what you added or updated.

Operating System: Windows
Language: Assembly
Editor used: VS Code

@SubhasmitaSw SubhasmitaSw reopened this Oct 5, 2020
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part, but there's a bit of cleaning up to do. Can we remove the .exe and .obj files? Also, can we move the .asm file to its proper folder.

@jrg94 jrg94 changed the title Added helloworld in Assembler using debug.exe #1868 Added Hello World in Debug.exe Oct 5, 2020
@jrg94 jrg94 self-assigned this Oct 5, 2020
@jrg94 jrg94 added enhancement Any code that improves the repo hello world See: https://sampleprograms.io/projects/hello-world/ labels Oct 5, 2020
@jrg94 jrg94 added this to the 1,000 Code Snippets milestone Oct 5, 2020
@SubhasmitaSw
Copy link
Contributor Author

@jrg94 Thank you for guiding me, I've updated the required changes.

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jrg94 jrg94 merged commit 97d15b1 into TheRenegadeCoder:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo hello world See: https://sampleprograms.io/projects/hello-world/
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add Hello World in Assembler Using Debug.exe
2 participants