Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Fizz Buzz in Clojure #2148

Merged
merged 2 commits into from
Oct 4, 2020
Merged

Added Fizz Buzz in Clojure #2148

merged 2 commits into from
Oct 4, 2020

Conversation

cristiano2lopes
Copy link
Contributor

Complete the Applicable Sections Below

Code Snippets

  • I named the pull request using Added/Updated <Sample Program> in <Language> format
  • I created/updated the language README
  • I added the sample program name to the README
  • [] I added fun facts (i.e. debut developer, typing, etc.)
  • I added reference link(s) to the README
  • I added solution citations when necessary (see [plagiarism][2])

Notes

Fizz Buzz in Clojure

@jrg94 jrg94 self-assigned this Oct 4, 2020
@jrg94 jrg94 requested a review from a team October 4, 2020 18:13
@jrg94 jrg94 added enhancement Any code that improves the repo fizz buzz See: https://sampleprograms.io/projects/fizz-buzz/ labels Oct 4, 2020
@jrg94 jrg94 added this to the 1,000 Code Snippets milestone Oct 4, 2020
jrg94
jrg94 requested changes Oct 4, 2020
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! The only issue I see is that you have this program expecting input. I believe Fizz Buzz is supposed to print the first 100. So, you can hardcode that: https://sample-programs.therenegadecoder.com/projects/fizz-buzz/

jrg94
jrg94 approved these changes Oct 4, 2020
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@jrg94 jrg94 merged commit 0505f5c into TheRenegadeCoder:master Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrg94 jrg94 jrg94 approved these changes

Assignees

@jrg94 jrg94

Labels
enhancement Any code that improves the repo fizz buzz See: https://sampleprograms.io/projects/fizz-buzz/
Projects
Code Snippets
Archived in project
Milestone
1,000 Code Snippets
Development

Successfully merging this pull request may close these issues.

Add Fizz Buzz in Clojure
2 participants
@cristiano2lopes @jrg94