Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Sleep Sort Testing #2165

Merged
merged 8 commits into from
Oct 6, 2020
Merged

Added Sleep Sort Testing #2165

merged 8 commits into from
Oct 6, 2020

Conversation

jrg94
Copy link
Member

@jrg94 jrg94 commented Oct 6, 2020

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.

Complete the Applicable Sections Below

Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.

  • I fixed #your-issue-number-here

Code Snippets

  • I named the pull request using Added/Updated <Sample Program> in <Language> format
  • I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

Testing

  • I named the pull request using Added/Updated <Language>/<Project> Testing format
  • I followed the testinfo template, if applicable

Notes

Once merged, this will allow us to reach the 25 project tests milestone.

@jrg94 jrg94 requested a review from a team October 6, 2020 02:48
@jrg94 jrg94 self-assigned this Oct 6, 2020
@jrg94 jrg94 marked this pull request as draft October 6, 2020 02:48
@jrg94 jrg94 added enhancement Any code that improves the repo tests Testing related labels Oct 6, 2020
@jrg94 jrg94 added this to the 25 Project Tests milestone Oct 6, 2020
@jrg94
Copy link
Member Author

jrg94 commented Oct 6, 2020

I know why Dart is broken, but I'm literally too inexperienced with the language to fix it. Apparently, the script only works with input in this form: 6 4 5. It needs to work with input in this form: 6, 4, 5.

@jrg94 jrg94 marked this pull request as ready for review October 6, 2020 15:53
@jrg94 jrg94 merged commit 29d4cad into master Oct 6, 2020
@jrg94 jrg94 deleted the sleep-sort branch October 6, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo tests Testing related
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant