Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated First Interaction Action With pull_request_target #2182

Merged
merged 3 commits into from
Oct 7, 2020
Merged

Conversation

jrg94
Copy link
Member

@jrg94 jrg94 commented Oct 7, 2020

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!

Other Notes

See this issue: actions/first-interaction#10

Basically, having a message sent to new contributors breaks for anyone on a fork. That's literally all of our contributors, so this was useless.

@jrg94 jrg94 requested a review from a team October 7, 2020 15:16
@jrg94 jrg94 self-assigned this Oct 7, 2020
@jrg94 jrg94 added the bug Something isn't working label Oct 7, 2020
@jrg94 jrg94 changed the title Removed First Interaction Action Updated First Interaction Action Oct 7, 2020
@jrg94
Copy link
Member Author

jrg94 commented Oct 7, 2020

Nevermind! The thread is so long that a potential solution seems to be buried in it. Hopefully this change sorts things out.

@jrg94 jrg94 changed the title Updated First Interaction Action Updated First Interaction Action With pull_request_target Oct 7, 2020
@jrg94 jrg94 merged commit 2f40b07 into master Oct 7, 2020
@jrg94 jrg94 deleted the greetings branch October 7, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant