Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified Test File in Clojure #2192

Merged
merged 2 commits into from
Oct 8, 2020
Merged

Modified Test File in Clojure #2192

merged 2 commits into from
Oct 8, 2020

Conversation

jrg94
Copy link
Member

@jrg94 jrg94 commented Oct 8, 2020

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution

I Am Modifying an Existing Code Snippet or Existing Tests

  • I fixed Clojure Tests Are Breaking #2191
  • I have read about modifying existing code snippets or tests in the contributing documentation
  • I have explained why this modification is necessary either in the issue linked above or in the notes below
  • I named the pull request using Modify {PROJECT} {tests} in {LANGUAGE} format

@jrg94 jrg94 requested a review from a team October 8, 2020 20:57
@jrg94 jrg94 self-assigned this Oct 8, 2020
@jrg94 jrg94 added enhancement Any code that improves the repo tests Testing related labels Oct 8, 2020
@jrg94 jrg94 changed the title Trying a Different Clojure Tag Modified Test File in Clojure Oct 8, 2020
@jrg94
Copy link
Member Author

jrg94 commented Oct 8, 2020

Alright, this should fix our Clojure issue. Clearly, the original image was pulling latest which caused this issue.

@jrg94 jrg94 merged commit b7d955e into master Oct 8, 2020
@jrg94 jrg94 deleted the clojure-build-bug branch October 8, 2020 21:23
@auroq
Copy link
Contributor

auroq commented Oct 8, 2020

Generally, I'm all for tagging a specific version, but I wonder if we should try to solve the original issue as well so we don't fall behind. Coincidentally, I've been looking at adding testing for lisp today. I can take a look at this next.

@jrg94
Copy link
Member Author

jrg94 commented Oct 8, 2020

Oh for sure! I noticed our trend in some of the other languages was to use tagged versions. I don't mind updating the versions, but I think that should be opt-in. In other words, we should manually update test versions rather than depend on "latest". Otherwise, we end up with these situations where branches start failing at random. Of course, the risk of falling behind is definitely there.

@auroq
Copy link
Contributor

auroq commented Oct 8, 2020

Ya, I agree completely. I guess the way to not fall behind is that anyone who wants to contribute to an existing language and wants/needs a new version will be responsible for updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo tests Testing related
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Clojure Tests Are Breaking
2 participants