Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Convex Hull in C# #2234

Merged
merged 2 commits into from
Oct 23, 2020
Merged

Added Convex Hull in C# #2234

merged 2 commits into from
Oct 23, 2020

Conversation

SirePi
Copy link
Contributor

@SirePi SirePi commented Oct 15, 2020

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.

Please fill one of the sections below as applicable.
Please also add any other relevant information to the Notes section at the bottom.
You may delete or just ignore any other sections.
For more information please refer to our contributing documentation

I Am Adding a New Code Snippet in an Existing Language

  • I fixed #your-issue-number-here
  • I named the pull request using Add {PROJECT} in {LANGUAGE} format
  • I created/updated the language README (see contributing documentation)
    • I added the sample program name to the README
    • I added fun facts (i.e. debut developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

Other Notes

Added relevant test cases to TheRenegadeCoder/sample-programs-website#359

@jrg94 jrg94 requested a review from a team October 16, 2020 00:49
@jrg94 jrg94 self-assigned this Oct 16, 2020
@jrg94 jrg94 added convex hull See: https://sampleprograms.io/projects/convex-hull/ enhancement Any code that improves the repo labels Oct 16, 2020
@jrg94 jrg94 added this to the 1,000 Code Snippets milestone Oct 16, 2020
@jrg94
Copy link
Member

jrg94 commented Oct 16, 2020

Will take a peek after we get the documentation merged.

@jrg94 jrg94 changed the title Added ConvexHull in C# Added Convex Hull in C# Oct 16, 2020
@jrg94 jrg94 added the needs tests New language or project that isn't tested label Oct 16, 2020
@SirePi
Copy link
Contributor Author

SirePi commented Oct 22, 2020

Fixed the code style to be compliant with the general style
(also can this be tagged hacktoberfest-accepted as well? 😄 )

jrg94
jrg94 approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'm going to merge this now, but we'll need to actually add the testing at some point.

@jrg94 jrg94 merged commit ae0789c into TheRenegadeCoder:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrg94 jrg94 jrg94 approved these changes

Assignees

@jrg94 jrg94

Labels
convex hull See: https://sampleprograms.io/projects/convex-hull/ enhancement Any code that improves the repo needs tests New language or project that isn't tested
Projects
Code Snippets
Archived in project
Milestone
1,000 Code Snippets
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SirePi @jrg94