-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Longest Palindromic Substring in JavaScript #2246
Added Longest Palindromic Substring in JavaScript #2246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @izexi! Thanks for contributing to this project! We are a rather small team, so it may take some time to process this request. In the meantime, there are several ways you can make yourself a part of The Renegade Coder community. For instance, you can:
- Subscribe to the monthly newsletter
- Become a patron
- Join us on Discord
- And, check out the rest of the list which includes links to The Renegade Coder YouTube channel and Twitter account
Thanks for your help!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I don't believe we have testing setup yet. Would you be interested in helping us set that up?
Sure, I could look into opening a PR for this sometime tomorrow, just to be clear are you referring to adding a |
It's actually a somewhat complex process. There are three files that need to be added/updated:
The first two are relatively straightforward. Then, you'd need to add a |
One thing worth mentioning is that we might want to add/change tests depending on what makes sense. Also, we need to decided on a file name. Longest Palindromic Substring is a bit long, but I'm not against using that straight up. That said, we've used LCS in the past for Longest Common Subsequence. |
Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.
Please fill one of the sections below as applicable.
Please also add any other relevant information to the Notes section at the bottom.
You may delete or just ignore any other sections.
For more information please refer to our contributing documentation
I Am Adding a New Code Snippet in an Existing Language
Add {PROJECT} in {LANGUAGE}
format