Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Longest Palindromic Substring Tests #2275

Merged
merged 8 commits into from Oct 26, 2020

Conversation

izexi
Copy link
Contributor

@izexi izexi commented Oct 18, 2020

I Am Adding New Tests for a Project

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I appreciate you taking the time to do this. I'm going to revisit our documentation and try to make the output a bit cleaner.

test/projects/test_lps.py Outdated Show resolved Hide resolved
test/projects/test_lps.py Outdated Show resolved Hide resolved
@jrg94 jrg94 self-assigned this Oct 19, 2020
@jrg94 jrg94 added enhancement Any code that improves the repo longest palindromic substring See: https://sampleprograms.io/projects/longest-palindromic-substring/ tests Testing related labels Oct 19, 2020
@jrg94 jrg94 added this to the 50 Project Tests milestone Oct 19, 2020
@jrg94
Copy link
Member

jrg94 commented Oct 23, 2020

I'm going to fix up the LPS table now. We can revisit this shortly.

@jrg94
Copy link
Member

jrg94 commented Oct 23, 2020

See this! TheRenegadeCoder/sample-programs-website#376

This testing will be the standard. I'll be updating the rest of the document at some point to clarify that palindromes should be simple. In other words, the algorithm shouldn't know about spaces or casing (i.e. S != s).

see 9801987026e4e35aba0b96442b5d9517dc066b5e
@izexi
Copy link
Contributor Author

izexi commented Oct 24, 2020

@jrg94

  • I have updated the tests to match the simplified test table in TheRenegadeCoder/sample-programs-website@7dd9eff
  • Fixed the Go program so that it outputs expected results by applying the same logic as done in the JavaScript program
  • Refactored both Go and Python programs so that they actually consume the user inputted args
  • Refactored all programs to be able to ignore the casing and modified the output of all these programs to match the updated outputs in the test

@izexi izexi requested a review from jrg94 October 24, 2020 21:19
@jrg94
Copy link
Member

jrg94 commented Oct 26, 2020

Looks good! Build failed for unrelated reason.

@jrg94
Copy link
Member

jrg94 commented Oct 26, 2020

Renamed files, so they should get picked up during testing.

@jrg94 jrg94 changed the title Add Longest Palindromic Substring tests Added Longest Palindromic Substring Tests Oct 26, 2020
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! 👍

@jrg94 jrg94 merged commit 0b7c467 into TheRenegadeCoder:master Oct 26, 2020
@izexi izexi deleted the test/lps branch October 26, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo longest palindromic substring See: https://sampleprograms.io/projects/longest-palindromic-substring/ tests Testing related
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants