Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Import in C++ #2357

Merged
merged 2 commits into from
Nov 2, 2020
Merged

Added Import in C++ #2357

merged 2 commits into from
Nov 2, 2020

Conversation

manasmithamn
Copy link
Contributor

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.

Please fill one of the sections below as applicable.
Please also add any other relevant information to the Notes section at the bottom.
You may delete or just ignore any other sections.
For more information please refer to our contributing documentation

I Am Adding a New Code Snippet in an Existing Language

  • I fixed Add Import/Export in C++ #2354
  • I named the pull request using Add {PROJECT} in {LANGUAGE} format
  • I created/updated the language README (see contributing documentation)
    • I added the sample program name to the README
    • I added fun facts (i.e. debut developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

I Am Adding a New Code Snippet in a New Language

  • I fixed #your-issue-number-here
  • I named the pull request using Add {PROJECT} in {LANGUAGE} format
  • I added a testinfo.yml files (see [contributing documentation][contributing-new-language])
    • I used an officially supported docker image or one that I personally trust
  • I created/updated the language README (see contributing documentation)
    • I added the sample program name to the README
    • I added fun facts (i.e. debut developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

I Am Adding New Tests for a Project

  • I fixed #your-issue-number-here
  • I named the pull request using Add {PROJECT} tests format
  • I verified the project exists on the Sample Programs Project List
  • I added tests for every test case in the Testing table of the project description for the given project. (See contributing documentation)

I Am Adding New Tests for a Language

  • I fixed #your-issue-number-here
  • I named the pull request using Add {LANGUAGE} tests format\
  • I added a testinfo.yml files (see [contributing documentation][contributing-new-language])
    • I used an officially supported docker image or one that I personally trust
  • I verified all tests are passing

I Am Modifying an Existing Code Snippet or Existing Tests

  • I fixed #your-issue-number-here
  • I have read about modifying existing code snippets or tests in the contributing documentation
  • I have explained why this modification is necessary either in the issue linked above or in the notes below
  • I named the pull request using Modify {PROJECT} {tests} in {LANGUAGE} format

Other Notes

Add notes here...

@jrg94 jrg94 changed the title export file in C++ Added Export in C++ Nov 1, 2020
@jrg94 jrg94 requested a review from a team November 1, 2020 23:27
@jrg94 jrg94 self-assigned this Nov 1, 2020
@jrg94 jrg94 added enhancement Any code that improves the repo import/export labels Nov 1, 2020
@jrg94 jrg94 added this to the 1,000 Code Snippets milestone Nov 1, 2020
@jrg94 jrg94 changed the title Added Export in C++ Added Import in C++ Nov 1, 2020
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jrg94 jrg94 merged commit 400640f into TheRenegadeCoder:master Nov 2, 2020
@manasmithamn
Copy link
Contributor Author

Thank you for accepting this request.

Is there anything wrong in this?

This is not showing up in https://hacktoberfest.digitalocean.com/profile for me...

@jrg94
Copy link
Member

jrg94 commented Nov 3, 2020

I'm not sure. The repo still has the proper tag and this was accepted and merged. Perhaps it has something to do with timing. It says 3 days ago. Was it still October at that point? Also, are the commits made with the same email you used for hacktoberfest?

@manasmithamn
Copy link
Contributor Author

manasmithamn commented Nov 3, 2020

Many thanks for the reply sir..

Yes commits are with same account..

If you can be kind enough to see the screenshots.. The legend says

Pending
Your PR has not yet been accepted by a maintainer.

 A maintainer can accept your PR by merging it, 
adding the "hacktoberfest-accepted" label to it, or 
approving it.

I'm perplexed..I submitted requests around 3 PM Oct 31..

Status in GitHub shows merged...

Unable to see where is the disconnect...

Worked fine for file write & read in R Language.. But for my favourite C & c ++ ...

These are not accepted
Screenshot_20201104-050754
Screenshot_20201104-050744
Screenshot_20201104-050730
Screenshot_20201104-050716

@jrg94
Copy link
Member

jrg94 commented Nov 4, 2020

I think you're waiting on some of your pull requests to mature. There's a 14 day wait. After that, you should be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add Import/Export in C++
2 participants