Pulled README Generation Out Into Its Own Workflow #2408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrg94
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this idea to include [skip-ci] in the commit message of README generation. I did this because I didn't want READMEs to be generated on the main branch, only on pull requests. Unfortunately, when I squash pull requests, the [skip-ci] message is added to the aggregate pull request causing the deployment not to run (i.e., no updated wiki).
Right now, I've chosen to remove that message from commit, but I'm thinking there may be a way to separate these out into different actions, so READMEs are only generated on pull requests. Unfortunately, testing will be run twice. This is another thing I was trying to avoid. Something to think about.