Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README Workflow Works on Push Only #2466

Merged
merged 1 commit into from
Oct 4, 2021
Merged

README Workflow Works on Push Only #2466

merged 1 commit into from
Oct 4, 2021

Conversation

jrg94
Copy link
Member

@jrg94 jrg94 commented Oct 4, 2021

README workflow doesn't appear to work on pull requests. I read that if we switch the workflow over to push, then it should work on forks. This couldn't hurt considering everything we do is through branches. The only reason I set it up for pull requests was to ensure READMEs were never built on main. As long as we maintain pull request workflow, this should be a non-issue.

@jrg94 jrg94 requested a review from a team October 4, 2021 14:10
@jrg94 jrg94 self-assigned this Oct 4, 2021
@jrg94 jrg94 added the enhancement Any code that improves the repo label Oct 4, 2021
@jrg94 jrg94 merged commit f584da6 into main Oct 4, 2021
@jrg94 jrg94 deleted the push branch October 4, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant