Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Josephus Problem Tests #2486

Merged
merged 6 commits into from
Oct 9, 2021
Merged

Added Josephus Problem Tests #2486

merged 6 commits into from
Oct 9, 2021

Conversation

PainOchoco
Copy link
Contributor

I Am Adding New Tests for a Project

  • I fixed Add Josephus Problem Testing #2478
  • I named the pull request using Add {PROJECT} tests format
  • I verified the project exists on the [Sample Programs Project List][sample-programs-project-list]
  • I added tests for every test case in the Testing table of the project description for the given project.

Other Notes

Should work fine, tell me if there's something I missed, I added tests from the Josephus Problem project page

@PainOchoco
Copy link
Contributor Author

Cant seem to work well, could you explain me a bit how these tests works? thanks!

@PainOchoco
Copy link
Contributor Author

Oh well it works now! I figured it out myself ^^

@jrg94 jrg94 changed the title Added Josephus Problem tests Added Josephus Problem Tests Oct 9, 2021
@jrg94 jrg94 self-assigned this Oct 9, 2021
@jrg94 jrg94 added enhancement Any code that improves the repo hacktoberfest Hacktoberfest related tests Testing related labels Oct 9, 2021
@jrg94 jrg94 added this to In progress in Sample Programs via automation Oct 9, 2021
@jrg94 jrg94 added this to the 50 Project Tests milestone Oct 9, 2021
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! I appreciate you putting together these tests. Glad you were able to figure things out.

@jrg94 jrg94 merged commit 53890a6 into TheRenegadeCoder:main Oct 9, 2021
Sample Programs automation moved this from In progress to Done Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo hacktoberfest Hacktoberfest related tests Testing related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add Josephus Problem Testing
2 participants