-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Link errors in Obective-C Readme #2528
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Rakesh9100! Thanks for contributing to this project! We are a rather small team, so it may take some time to process this request. In the meantime, there are several ways you can make yourself a part of The Renegade Coder community. For instance, you can:
- Subscribe to the monthly newsletter
- Become a patron
- Join us on Discord
- And, check out the rest of the list which includes links to The Renegade Coder YouTube channel and Twitter account
Thanks for your help!
@Rakesh9100 thanks for pointing this out! I hadn't noticed this before. I have a bit of bad news... the READMEs are automated, so this change will revert as soon as we merge it. We'll have to make this fix here most likely. |
I believe I've found the bug: https://github.com/TheRenegadeCoder/sample-programs-readmes/blob/6cc3287f4f3522dfafa1694cb14e5a6dd54d3422/ronbun/readme.py#L87 Turns out, some language names are multiple words. This line will need to be updated to reflect that (seems like an easy change). |
Whoops! I think this is the correct line: https://github.com/TheRenegadeCoder/sample-programs-readmes/blob/6cc3287f4f3522dfafa1694cb14e5a6dd54d3422/ronbun/readme.py#L84 |
Yes i think automated readmes can be changed if I am not wrong in the piece of your code. You can merge the request from my side too. |
Alright, I'll merge this and we can look to fix this issue on the automation side. |
If you're interested in fixing this issue, I made it here: TheRenegadeCoder/sample-programs-readmes#9 |
Yes, it should be done on the automation side only, since the merging didn't work. I will surely look into this issue. |
Congrats on taking the first step to contributing to the Sample Programs repository maintained by [The Renegade Coder][renegade-coder]!
For simplicity, please make sure that your pull request includes one and only one contribution.
Other Notes
Fixed the Link errors as it displayed the full URL, which was an error in the content Missing Programs.
Had the problem in all the content of Missing programs from 1 to 30 so fixed them all.