Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Link errors in Obective-C Readme #2528

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Fixed Link errors in Obective-C Readme #2528

merged 1 commit into from
Dec 14, 2021

Conversation

Rakesh9100
Copy link
Contributor

Congrats on taking the first step to contributing to the Sample Programs repository maintained by [The Renegade Coder][renegade-coder]!
For simplicity, please make sure that your pull request includes one and only one contribution.

Other Notes

Fixed the Link errors as it displayed the full URL, which was an error in the content Missing Programs.

Had the problem in all the content of Missing programs from 1 to 30 so fixed them all.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Rakesh9100! Thanks for contributing to this project! We are a rather small team, so it may take some time to process this request. In the meantime, there are several ways you can make yourself a part of The Renegade Coder community. For instance, you can:

Thanks for your help!

@jrg94
Copy link
Member

jrg94 commented Dec 13, 2021

@Rakesh9100 thanks for pointing this out! I hadn't noticed this before. I have a bit of bad news... the READMEs are automated, so this change will revert as soon as we merge it. We'll have to make this fix here most likely.

@jrg94
Copy link
Member

jrg94 commented Dec 13, 2021

I believe I've found the bug: https://github.com/TheRenegadeCoder/sample-programs-readmes/blob/6cc3287f4f3522dfafa1694cb14e5a6dd54d3422/ronbun/readme.py#L87

Turns out, some language names are multiple words. This line will need to be updated to reflect that (seems like an easy change).

@jrg94 jrg94 self-assigned this Dec 13, 2021
@jrg94 jrg94 added the bug Something isn't working label Dec 13, 2021
@jrg94 jrg94 added this to In progress in Sample Programs via automation Dec 13, 2021
@jrg94
Copy link
Member

jrg94 commented Dec 13, 2021

@Rakesh9100
Copy link
Contributor Author

Rakesh9100 commented Dec 14, 2021

@Rakesh9100 thanks for pointing this out! I hadn't noticed this before. I have a bit of bad news... the READMEs are automated, so this change will revert as soon as we merge it. We'll have to make this fix here most likely.

Yes i think automated readmes can be changed if I am not wrong in the piece of your code. You can merge the request from my side too.

@jrg94
Copy link
Member

jrg94 commented Dec 14, 2021

Alright, I'll merge this and we can look to fix this issue on the automation side.

@jrg94 jrg94 merged commit a64271a into TheRenegadeCoder:main Dec 14, 2021
Sample Programs automation moved this from In progress to Done Dec 14, 2021
@jrg94
Copy link
Member

jrg94 commented Dec 14, 2021

If you're interested in fixing this issue, I made it here: TheRenegadeCoder/sample-programs-readmes#9

@Rakesh9100
Copy link
Contributor Author

Rakesh9100 commented Dec 14, 2021

Alright, I'll merge this and we can look to fix this issue on the automation side.

Yes, it should be done on the automation side only, since the merging didn't work. I will surely look into this issue.

@Rakesh9100 Rakesh9100 deleted the my-objective-c branch April 2, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants