Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BinarySearch for Java #2558

Merged
merged 5 commits into from
Oct 2, 2022
Merged

Conversation

vipin0
Copy link
Contributor

@vipin0 vipin0 commented Oct 1, 2022

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.

Please fill one of the sections below as applicable.
Please also add any other relevant information to the Notes section at the bottom.
You may delete or just ignore any other sections.
For more information please refer to our contributing documentation

I Am Adding a New Code Snippet in an Existing Language

  • I fixed #your-issue-number-here
  • I named the pull request using Added BinarySearch for Java format

I Am Adding a New Code Snippet in a New Language

  • I fixed #your-issue-number-here
  • I named the pull request using Add {PROJECT} in {LANGUAGE} format
  • I added a testinfo.yml files (see [contributing documentation][contributing-new-language])
    • I used an officially supported docker image or one that I personally trust

I Am Adding New Tests for a Project

  • I fixed #your-issue-number-here
  • I named the pull request using Add {PROJECT} tests format
  • I verified the project exists on the Sample Programs Project List
  • I added tests for every test case in the Testing table of the project description for the given project. (See contributing documentation)

I Am Adding New Tests for a Language

  • I fixed #your-issue-number-here
  • I named the pull request using Add {LANGUAGE} tests format\
  • I added a testinfo.yml files (see [contributing documentation][contributing-new-language])
    • I used an officially supported docker image or one that I personally trust
  • I verified all tests are passing

I Am Modifying an Existing Code Snippet or Existing Tests

  • I fixed #your-issue-number-here
  • I have read about modifying existing code snippets or tests in the contributing documentation
  • I have explained why this modification is necessary either in the issue linked above or in the notes below
  • I named the pull request using Modify {PROJECT} {tests} in {LANGUAGE} format

Other Notes

Add notes here...

@jrg94 jrg94 self-requested a review October 1, 2022 16:37
@jrg94 jrg94 self-assigned this Oct 1, 2022
@jrg94 jrg94 added enhancement Any code that improves the repo hacktoberfest Hacktoberfest related binary search See: https://sampleprograms.io/projects/binary-search/ labels Oct 1, 2022
@jrg94 jrg94 added this to the 1,000 Code Snippets milestone Oct 1, 2022
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right idea, but there are some issues. See comments.

archive/j/java/BinarySearch.java Outdated Show resolved Hide resolved
@vipin0 vipin0 force-pushed the binarySearch branch 2 times, most recently from aea0daa to 274d436 Compare October 1, 2022 18:20
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can remove the C++ code from this, it should be good to go.

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@jrg94 jrg94 merged commit 27b1b61 into TheRenegadeCoder:main Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binary search See: https://sampleprograms.io/projects/binary-search/ enhancement Any code that improves the repo hacktoberfest Hacktoberfest related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants