Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Algol68 tests #2695

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Add Algol68 tests #2695

merged 1 commit into from
Jan 18, 2023

Conversation

rzuckerm
Copy link
Collaborator

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.

Please fill one of the sections below as applicable.
Please also add any other relevant information to the Notes section at the bottom.
You may delete or just ignore any other sections.
For more information please refer to our contributing documentation

I Am Adding a New Code Snippet in an Existing Language

  • I fixed #your-issue-number-here
  • I named the pull request using Add {PROJECT} in {LANGUAGE} format

I Am Adding a New Code Snippet in a New Language

  • I fixed #your-issue-number-here
  • I named the pull request using Add {PROJECT} in {LANGUAGE} format
  • I added a testinfo.yml files (see [contributing documentation][contributing-new-language])
    • I used an officially supported docker image or one that I personally trust

I Am Adding New Tests for a Project

  • I fixed #your-issue-number-here
  • I named the pull request using Add {PROJECT} tests format
  • I verified the project exists on the Sample Programs Project List
  • I added tests for every test case in the Testing table of the project description for the given project. (See contributing documentation)

I Am Adding New Tests for a Language

  • I fixed Add Algol68 Testing #2694
  • I named the pull request using Add {LANGUAGE} tests format\
  • I added a testinfo.yml files (see [contributing documentation][contributing-new-language])
    • I used an officially supported docker image or one that I personally trust
  • I verified all tests are passing

I Am Modifying an Existing Code Snippet or Existing Tests

  • I fixed #your-issue-number-here
  • I have read about modifying existing code snippets or tests in the contributing documentation
  • I have explained why this modification is necessary either in the issue linked above or in the notes below
  • I named the pull request using Modify {PROJECT} {tests} in {LANGUAGE} format

Other Notes

I couldn't get the tests to work locally, but I was able to run hello-world locally with this:

$ (venv) ./samplerunner.sh run -l algol68

Running "hello-world.alg"...
Hello, World!

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rzuckerm! Thanks for contributing to this project! We are a rather small team, so it may take some time to process this request. In the meantime, there are several ways you can make yourself a part of The Renegade Coder community. For instance, you can:

Thanks for your help!

@rzuckerm rzuckerm marked this pull request as ready for review January 17, 2023 16:16
@jrg94 jrg94 self-assigned this Jan 18, 2023
@jrg94 jrg94 requested a review from a team January 18, 2023 01:16
@jrg94 jrg94 added enhancement Any code that improves the repo tests Testing related labels Jan 18, 2023
@jrg94 jrg94 added this to the 50 Language Tests milestone Jan 18, 2023
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Looks like it ran.

@jrg94 jrg94 merged commit b080e08 into TheRenegadeCoder:main Jan 18, 2023
@rzuckerm rzuckerm deleted the algol68-tests branch January 18, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo tests Testing related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Algol68 Testing
2 participants