Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fizz-buzz in Algol68 #2699

Merged
merged 4 commits into from
Jan 19, 2023
Merged

Conversation

rzuckerm
Copy link
Collaborator

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.

Please fill one of the sections below as applicable.
Please also add any other relevant information to the Notes section at the bottom.
You may delete or just ignore any other sections.
For more information please refer to our contributing documentation

I Am Adding a New Code Snippet in an Existing Language

I Am Adding a New Code Snippet in a New Language

  • I fixed #your-issue-number-here
  • I named the pull request using Add {PROJECT} in {LANGUAGE} format
  • I added a testinfo.yml files (see [contributing documentation][contributing-new-language])
    • I used an officially supported docker image or one that I personally trust

I Am Adding New Tests for a Project

  • I fixed #your-issue-number-here
  • I named the pull request using Add {PROJECT} tests format
  • I verified the project exists on the Sample Programs Project List
  • I added tests for every test case in the Testing table of the project description for the given project. (See contributing documentation)

I Am Adding New Tests for a Language

  • I fixed #your-issue-number-here
  • I named the pull request using Add {LANGUAGE} tests format\
  • I added a testinfo.yml files (see [contributing documentation][contributing-new-language])
    • I used an officially supported docker image or one that I personally trust
  • I verified all tests are passing

I Am Modifying an Existing Code Snippet or Existing Tests

  • I fixed #your-issue-number-here
  • I have read about modifying existing code snippets or tests in the contributing documentation
  • I have explained why this modification is necessary either in the issue linked above or in the notes below
  • I named the pull request using Modify {PROJECT} {tests} in {LANGUAGE} format

Other Notes

Am I supposed to write an article? I noticed that in my README that there was no article for Baklava in Algol68. If so, where are the instructions for how to do that?

@rzuckerm rzuckerm marked this pull request as ready for review January 19, 2023 01:20
@jrg94 jrg94 requested a review from a team January 19, 2023 02:01
@jrg94 jrg94 self-assigned this Jan 19, 2023
@jrg94 jrg94 added enhancement Any code that improves the repo fizz buzz See: https://sampleprograms.io/projects/fizz-buzz/ labels Jan 19, 2023
@jrg94 jrg94 added this to the 1,000 Code Snippets milestone Jan 19, 2023
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@jrg94 jrg94 merged commit 4ddcdbc into TheRenegadeCoder:main Jan 19, 2023
@rzuckerm rzuckerm deleted the algol68-fizzbuzz branch January 19, 2023 13:32
@rzuckerm
Copy link
Collaborator Author

@jrg94 I never got an answer to this question:

Am I supposed to write an article? I noticed that in my README that there was no article for Baklava in Algol68. If so, where are the instructions for how to do that?

@jrg94
Copy link
Member

jrg94 commented Jan 19, 2023

Articles aren't required, but you can write one if you'd like to help fill out the documentation side of things. The article site is somewhat in flux, and I haven't found a good way to organize it yet. So, there's no pressure to fill it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo fizz buzz See: https://sampleprograms.io/projects/fizz-buzz/
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add FizzBuzz in Algol68
2 participants