Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update glotter2 to 0.4.x #2926

Merged
merged 4 commits into from
Mar 3, 2023
Merged

Conversation

rzuckerm
Copy link
Collaborator

@rzuckerm rzuckerm commented Mar 2, 2023

See glotter2 Changlog versions 0.4.0 through 0.4.4 for details.

This reduces the workflow run time as follows:

  • Image download: ~8 min -> ~5 min
  • Test: ~18 min -> ~10 min

Your mileage may vary 馃槃 , but the above gives a coarse estimate of the time savings.

Also, I added a pytest.ini that changes the pytest progress display from percentage to number of tests completed vs total number of tests. When there are a lot of tests, this is more useful than seeing 99% forever 馃槂

fixed #2927

@rzuckerm rzuckerm changed the title Update glotter2 to 0.4.1 Update glotter2 to 0.4.x Mar 2, 2023
@rzuckerm rzuckerm marked this pull request as ready for review March 2, 2023 14:50
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤馃徏

@jrg94 jrg94 self-assigned this Mar 3, 2023
@jrg94 jrg94 added enhancement Any code that improves the repo tests Testing related labels Mar 3, 2023
@jrg94 jrg94 merged commit 232b3b4 into TheRenegadeCoder:main Mar 3, 2023
@rzuckerm rzuckerm deleted the glotter2-0.4.1 branch March 3, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo tests Testing related
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

Update to glotter2 0.4.x
2 participants