Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed shell shebang from bash to sh in samplerunner.sh #2941

Merged
merged 1 commit into from
Mar 19, 2023

Conversation

alope107
Copy link
Contributor

Adresses #2940

Changes the shell used in samplerunner.sh to make the script work on OSs that do not have bash installed.

@alope107
Copy link
Contributor Author

Apologies I didn't follow the nice PR template this repo provides - none of the sections looked like it was applicable this change.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @alope107! Thanks for contributing to this project! We are a rather small team, so it may take some time to process this request. In the meantime, there are several ways you can make yourself a part of The Renegade Coder community. For instance, you can:

Thanks for your help!

@rzuckerm rzuckerm self-requested a review March 19, 2023 21:04
@rzuckerm
Copy link
Collaborator

Apologies I didn't follow the nice PR template this repo provides - none of the sections looked like it was applicable this change.

@alope107 That's fine. If this PR passes the CI, I'll merge it. Thanks for your contribution!

@rzuckerm
Copy link
Collaborator

Apologies I didn't follow the nice PR template this repo provides - none of the sections looked like it was applicable this change.

@alope107 That's fine. If this PR passes the CI, I'll merge it. Thanks for your contribution!

OK, it looks like the CI build just runs python runner.py <args> directly, so this won't prove that whether this change will work. However, I just ran it on my Ubuntu 22.04 VM, and it worked just fine.

@alope107
Copy link
Contributor Author

Great, thanks so much for the swift review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants