Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Never Tests #3236

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Conversation

rzuckerm
Copy link
Collaborator

@rzuckerm rzuckerm commented Sep 2, 2023

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.

Please fill one of the sections below as applicable.
Please also add any other relevant information to the Notes section at the bottom.
You may delete or just ignore any other sections.
For more information please refer to our contributing documentation

I Am Modifying an Existing Code Snippet or Existing Tests

  • I fixed Modify Never Testing #3235
  • I have read about modifying existing code snippets or tests in the contributing documentation
  • I have explained why this modification is necessary either in the issue linked above or in the notes below
  • I named the pull request using Modify {PROJECT} {tests} in {LANGUAGE} format

Other Notes

Never just pushed a new commit to fix this never-lang/never#56. Now,-- --args doesn't need to be done, and the arguments start at index 0.

@rzuckerm rzuckerm added enhancement Any code that improves the repo tests Testing related labels Sep 2, 2023
@rzuckerm rzuckerm marked this pull request as ready for review September 2, 2023 15:52
@rzuckerm rzuckerm enabled auto-merge (squash) September 2, 2023 17:11
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@rzuckerm rzuckerm merged commit 1945153 into TheRenegadeCoder:main Sep 5, 2023
6 checks passed
@jrg94 jrg94 self-assigned this Sep 5, 2023
@rzuckerm rzuckerm deleted the upgrade-never-image branch September 5, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo tests Testing related
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

Modify Never Testing
2 participants