Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename and fix bad Typescript samples #3485

Merged
merged 2 commits into from
Oct 21, 2023
Merged

Rename and fix bad Typescript samples #3485

merged 2 commits into from
Oct 21, 2023

Conversation

rzuckerm
Copy link
Collaborator

I fixed #3484

@rzuckerm rzuckerm added the bug Something isn't working label Oct 20, 2023
@rzuckerm rzuckerm marked this pull request as ready for review October 21, 2023 02:51
jrg94
jrg94 approved these changes Oct 21, 2023
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! I was having very weird issues on the git side of things as well.

@jrg94 jrg94 self-assigned this Oct 21, 2023
@jrg94 jrg94 merged commit f5e1a0e into TheRenegadeCoder:main Oct 21, 2023
6 checks passed
@rzuckerm rzuckerm deleted the rename-typescript-samples branch October 21, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrg94 jrg94 jrg94 approved these changes

Assignees

@jrg94 jrg94

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix bad Typescript samples
2 participants
@rzuckerm @jrg94