Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Verve Tests #3666

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Add Verve Tests #3666

merged 1 commit into from
Dec 20, 2023

Conversation

rzuckerm
Copy link
Collaborator

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.

Please fill one of the sections below as applicable.
Please also add any other relevant information to the Notes section at the bottom.
You may delete or just ignore any other sections.
For more information please refer to our contributing documentation

I Am Adding New Tests for a Language

  • I fixed Add Verve Testing #3665
  • I named the pull request using Add {LANGUAGE} Tests format
  • I added a testinfo.yml files (see contributing documentation)
    • I used an officially supported docker image or one that I personally trust
  • I verified all tests are passing

Other Notes

The Verve language is extremely immature. It lacks some very basic features like being able to add strings and lists, which makes it unusable for any of the more complex samples. Development seems to have stopped around 2018. There was a recent commit that seems to have broken the project to the build where it couldn't build. It wasn't until I went back one commit that I was able to build the project and create the docker image.

@rzuckerm rzuckerm added enhancement Any code that improves the repo tests Testing related labels Dec 17, 2023
@rzuckerm rzuckerm marked this pull request as ready for review December 17, 2023 20:27
@jrg94 jrg94 requested a review from a team December 20, 2023 00:26
@jrg94 jrg94 self-assigned this Dec 20, 2023
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice trick to clean up the output.

@jrg94 jrg94 merged commit 5826180 into TheRenegadeCoder:main Dec 20, 2023
6 checks passed
@rzuckerm rzuckerm deleted the add-verve-tests branch December 20, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo tests Testing related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Verve Testing
2 participants