Added Game of Life in Haskell #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No sweat with libraries! I'm actually all for it if it simplifies the implementation. I'm more so worried about external dependencies as it makes life much more difficult when testing. |
|
Sorry. I should have been more clear. That's what I meant by libraries. ArgParser is an external dependency that's used to parse the CLI input and provide help text and error handling. All the other libraries ship with ghc (the haskell compiler). |
|
Ahh! Makes sense. Well, to be fair, Game of Life is a bit of an undertaking in any language. It's a bit different than a lot of our current projects. |
|
Doing some pull request decluttering. Going to pull this in, and we can make an issue for working on it in the future. |
jrg94
approved these changes
Mar 30, 2019
jrg94
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Congrats on taking the first step to contributing to the Sample Programs in Every Language repository!
For simplicity, please make sure that your pull request includes one and only one sample program and language.
Please Complete the Following
<Sample Program> in <Language>formatNotes
This is not yet ready, but since it is long I thought it would be good to start a review of it.
Currently it only uses the CLI for the UI (which is hard enough in haskell by itself).
I also plan to change the way it determines initial spawn locations.
This does require one library to run: argparser. I noted that at the top of the file. If necessary, I can remove that, but it won't be nearly as pretty. I know we try to avoid this elsewhere, but I noticed some other game of life implementations, such as python, use libraries in order to do the GUI.