Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOT-854 sentry #341

Merged
merged 3 commits into from Jun 24, 2021
Merged

DOT-854 sentry #341

merged 3 commits into from Jun 24, 2021

Conversation

edwh
Copy link
Collaborator

@edwh edwh commented Jun 24, 2021

This enables Sentry for Laravel and Vue.

Needed to up the version of the faker package for my composer install to work.

@edwh edwh requested a review from ngm June 24, 2021 09:10
ngm
ngm approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@ngm ngm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me, and excited to see this set up!

Just some questions around what happens with regards to local environments.

.env.example Show resolved Hide resolved
resources/js/app.js Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jun 24, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@edwh edwh merged commit bcc8de0 into develop Jun 24, 2021
@ngm ngm deleted the DOT-854_sentry branch November 14, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngm ngm ngm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edwh @ngm