Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOT-1535 nearby groups radius #401

Merged
merged 7 commits into from
Oct 18, 2021
Merged

DOT-1535 nearby groups radius #401

merged 7 commits into from
Oct 18, 2021

Conversation

edwh
Copy link
Collaborator

@edwh edwh commented Sep 8, 2021

    • Change text for nearby groups.
    • Show group distance.
    • Don't limit number of groups as much.

@edwh edwh requested a review from ngm September 8, 2021 16:45
ngm
ngm reviewed Sep 10, 2021
View reviewed changes
resources/lang/en/groups.php Outdated Show resolved Hide resolved
ngm
ngm reviewed Sep 10, 2021
View reviewed changes
app/Traits/GlobalScopes.php Outdated
* @author Christopher Kelker 2020-02-18
* @return $query
*/
public function scopeCreatedWithinLastMonth($query)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This no longer needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find any evidence that it was. But double-check.

ngm
ngm reviewed Sep 10, 2021
View reviewed changes
Copy link
Contributor

@ngm ngm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good - will have a local test later.

@edwh edwh merged commit 9cde2cc into develop Oct 18, 2021
@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@restart-tech restart-tech deleted the DOT-1535_nearby_groups_radius branch December 1, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngm ngm ngm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edwh @ngm