Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RES-1917 group email #677

Merged
merged 4 commits into from
Sep 4, 2023
Merged

RES-1917 group email #677

merged 4 commits into from
Sep 4, 2023

Conversation

edwh
Copy link
Collaborator

@edwh edwh commented Aug 14, 2023

  1. Add migration for group email property.
  2. Add script to set this for MRES groups. Note that a few mismatch and will need to be set by hand.
  3. Add email to the API, and test it.
  4. Change client to expose email in group add/edit.
  5. Rejig group edit layout to make it neater, including mobile.
  6. Tweak translations a little bit to make the layout fit.

@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 11 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@edwh edwh requested a review from restart-neil August 14, 2023 15:44
@edwh edwh merged commit eda9d08 into develop Sep 4, 2023
2 of 5 checks passed
@ngm ngm deleted the RES-1917_group_email branch June 19, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngm ngm ngm approved these changes

@restart-neil restart-neil Awaiting requested review from restart-neil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edwh @ngm