Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected symbol "?" on Safari 12.1 #23

Closed
hyoretsu opened this issue Jul 13, 2023 · 1 comment · Fixed by #24
Closed

Unexpected symbol "?" on Safari 12.1 #23

hyoretsu opened this issue Jul 13, 2023 · 1 comment · Fixed by #24

Comments

@hyoretsu
Copy link
Contributor

hyoretsu commented Jul 13, 2023 •
edited
Loading

It throws an error on Safari 12.1, in both development and production. I also have a React lib that when transpiled used the ||= operator, which turns out was only supported in Safari 14.

It's probably the nullish coalescing you're using that isn't being polyfilled by tsup, since it's only supported by Safari 13.4 onwards.
hyoretsu added a commit to hyoretsu/nextjs-toploader that referenced this issue Jul 13, 2023
@hyoretsu
Target ES6 when building, to support older browsers
307ea60 
closes TheSGJ#23
@hyoretsu hyoretsu mentioned this issue Jul 13, 2023
Merged
@hyoretsu
Copy link
Contributor Author

Using ESNext as target, specially in a lib, isn't good. It can use features that very few browsers support.

hyoretsu added a commit to hyoretsu/nextjs-toploader that referenced this issue Jul 13, 2023
@hyoretsu
Target ES6 when building, to support older browsers
1661592 
closes TheSGJ#23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Target ES6 when building, to support older browsers hyoretsu/nextjs-toploader
1 participant
@hyoretsu