Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category blue pill #383

Merged
merged 4 commits into from
Sep 15, 2016
Merged

Category blue pill #383

merged 4 commits into from
Sep 15, 2016

Conversation

SimonLab
Copy link
Contributor

@SimonLab SimonLab commented Sep 14, 2016

see #343
As the location for the museum is not yet in the index the filters under the searchbox is only working for categories

@codecov-io
Copy link

codecov-io commented Sep 14, 2016

Current coverage is 98.90% (diff: 100%)

Merging #383 into master will increase coverage by <.01%

@@             master       #383   diff @@
==========================================
  Files            81         81          
  Lines          1536       1548    +12   
  Methods         145        147     +2   
  Messages          0          0          
  Branches        372        375     +3   
==========================================
+ Hits           1519       1531    +12   
  Misses           17         17          
  Partials          0          0          

Powered by Codecov. Last update dd55058...8c90a21

@SimonLab SimonLab added this to the Sprint 7 milestone Sep 14, 2016
@Danwhy
Copy link
Contributor

Danwhy commented Sep 14, 2016

LGTM 👍

module.exports = {
'Search from home Page': function (browser) {
browser
.url('http://localhost:8000/search?q=babbage')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ that you guys are consistent with adding front-end tests. 👍

@nelsonic
Copy link
Contributor

nelsonic commented Sep 15, 2016

@SimonLab 👀 👍 ❤️ ✅
Please ensure that we get the Test Coverage back up to 100% soon... it's so close!! 😉

@nelsonic nelsonic merged commit 543b910 into master Sep 15, 2016
@nelsonic nelsonic deleted the category-blue-pill branch September 15, 2016 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants