You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added "Lazy Loading" to the home page in order to accommodate the now 1017 Pokemon.
Used the official PokeAPI URLs to grab Pokemon images.
Changed the images from the dream world artwork to the official art to accommodate post-gem 5 Pokemon
Hey @TheShiveshNetwork I updated the search functionality but I have one question, Sinistcha, DEX#1013 currently doesn't have any official artwork or sprites as these are typically taken from promotional material or the games themselves. This may be because the Pokemon is too new / niche in the DLC for material to have been released yet.
I was wondering how you would want me to handle this unless it's fine that its card doesn't feature any artwork.
Added "Lazy Loading" to the home page in order to accommodate the now 1017 Pokemon. Used the official PokeAPI URLs to grab Pokemon images. Changed the images from the dream world artwork to the official art to accommodate post-gem 5 Pokemon
Great work @Namatuzio It's perfect, as of what I wanted.
And yeah tell me if you can add a static image of "image not found" or some styled text for the pokemons for which sprites aren't available, that would be great.
Kudos!!
Hey @TheShiveshNetwork I'm currently attempting to fix the conflicts with this pr and it seems like Infinite Scroll does this:
I was trying to work on a fix for this in my branch but I can't seem to properly replicate an infinitely scrolling page I believe it's because multiple API calls are made to keep re-fetching Pokemon and displaying them.
As for multiples of the same Pokemon showing up, I was wondering if this is okay. As always, please let me know, thank you 😊
@TheShiveshNetwork all done! If it's not too much trouble, would you be able to add the hacktoberfest-accepted label as well when you merge? Thanks again, I had a blast working on this functionality.
All good, great work @Namatuzio
Also I'd like to connect with you, we can build some better projects together may be.
If you have linkedin tell me.
Merging this one.
Welcome🍰!!!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9
Hey @TheShiveshNetwork I updated the search functionality but I have one question, Sinistcha, DEX#1013 currently doesn't have any official artwork or sprites as these are typically taken from promotional material or the games themselves. This may be because the Pokemon is too new / niche in the DLC for material to have been released yet.
I was wondering how you would want me to handle this unless it's fine that its card doesn't feature any artwork.
Thank you!