Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Spawn SCUD Storm Hole Worker after Toxin Puddle disappears - after 30 seconds instead of 20 seconds #1096

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

xezon
Copy link
Collaborator

@xezon xezon commented Sep 3, 2022

This change spawns the SCUD Storm Hole worker in 30 seconds instead of 20 seconds intervals. This will prevent the first worker from dying in the poison. No EVA event is triggered for damaging the spawned worker. Effectively a SCUD Storm can rebuild 10 seconds quicker than originally. The Toxin Field time has been adjusted to accommodate the Worker spawn time properly.

Object Build Time Repair Time Hole Repair Time Toxin Field Time
Original USA Particle 60 60 max
Original China Nuke 60 60 max
Original GLA SCUD 120 120 max 160 30
Original Demo GLA SCUD 120 120 max 160 30
Patched Demo GLA SCUD (1) 120 120 max 140
Patched GLA SCUD (this) 120 120 max 150 26
Patched Demo GLA SCUD (this) 120 120 max 150

Note: It is not possible to use an external worker to continue repair a GLA building from GLA hole. Therefore the reduction in Toxin Field time is practically inconsequential.

This proposal was originally discussed in:

Original

Worker spawns in the Toxin and dies.

shot_20220725_191426_7

Patched

Worker spawns just as the Toxin disappears.

scud_storm_worker.mp4

@xezon xezon added Design Is a matter of game design Controversial Is controversial Minor Severity: Minor < Major < Critical < Blocker labels Sep 3, 2022
@xezon xezon self-assigned this Sep 3, 2022
@xezon
Copy link
Collaborator Author

xezon commented Sep 3, 2022

Exile:

I'm willing to settle on 30 seconds

Jundiyy:

Well I think 30s is fair as well.
In original ZH, Scud repairs to 2%, so it gets some extra hp.
With a 30s delay, it means, for them 10 seconds, it won't have that hp.
This is still 10s faster than ZH but now with a small cost. So yea, 30s seems fair.

@xezon xezon requested a review from commy2 September 3, 2022 18:42
@commy2
Copy link
Collaborator

commy2 commented Sep 3, 2022

Why would the Worker come up for the Scud Storm later than for other buildings though? This change breaks consistency all for a super minor balance thing that essentially never comes into play.

@xezon
Copy link
Collaborator Author

xezon commented Sep 3, 2022

The Worker comes after the Toxin Puddle clears. If he comes before that, he dies. I do not think the consistency argument is a strong argument. Logically Worker waits until Toxin Puddle is gone, so it is ok if it takes longer than other buildings. Other buildings do not spawn a Toxin Puddle.

If we would change Toxin Puddle from 30 seconds to 20 seconds, then that would require new Toxin Puddle setup and we would introduce inconsistent Puddle Times.

@xezon xezon force-pushed the fix-scud-storm-poison-kills-first-worker-2 branch from 54fb1d3 to caf13c1 Compare September 4, 2022 10:58
@xezon
Copy link
Collaborator Author

xezon commented Sep 4, 2022

I optimized timings. Worker now spawns in 30000 ms instead of 30100 ms, and the Toxin Field timings are individually tweaked for Scud Storm to accommodate first spawning Worker. Video attached.

@xezon xezon changed the title Fix: SCUD Storm Hole Worker spawns after 30 seconds instead of 20 seconds Fix: Spawn SCUD Storm Hole Worker after Toxin Puddle disappears - after 30 seconds instead of 20 seconds Sep 4, 2022
@xezon xezon force-pushed the fix-scud-storm-poison-kills-first-worker-2 branch from caf13c1 to 02f40f5 Compare September 19, 2022 12:30
@xezon
Copy link
Collaborator Author

xezon commented Sep 19, 2022

Someone shall Approve this, then I will merge. Jundiyy, Exile and I are in favor of this. commy2 not in favor, because of hole worker spawn time inconsistency.

Copy link
Collaborator

@commy2 commy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The technical aspects work.

@ImTimK
Copy link
Collaborator

ImTimK commented Sep 19, 2022

I optimized timings. Worker now spawns in 30000 ms instead of 30100 ms, and the Toxin Field timings are individually tweaked for Scud Storm to accommodate first spawning Worker. Video attached.

Is it 30s for all buildings though?

@xezon
Copy link
Collaborator Author

xezon commented Sep 19, 2022

For all Scud Storms.

@xezon xezon merged commit c9a6ab6 into main Sep 20, 2022
@xezon xezon deleted the fix-scud-storm-poison-kills-first-worker-2 branch September 20, 2022 10:35
@ImTimK ImTimK added the GLA Affects GLA faction label Nov 6, 2022
@xezon xezon removed their assignment Jan 4, 2023
@xezon xezon added the Buff Makes a thing more powerful label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Buff Makes a thing more powerful Controversial Is controversial Design Is a matter of game design GLA Affects GLA faction Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
3 participants