Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add object experience document #1126

Merged
merged 2 commits into from
Sep 19, 2022
Merged

Add object experience document #1126

merged 2 commits into from
Sep 19, 2022

Conversation

xezon
Copy link
Collaborator

@xezon xezon commented Sep 5, 2022

No description provided.

@xezon xezon added the Documentation Is documentation or complementary resource label Sep 5, 2022
@xezon
Copy link
Collaborator Author

xezon commented Sep 6, 2022 •
edited
Loading

Issues:

  • Sheet does not allow to set patched values for units that start off with 0 XP, because 0 * Anything remains 0
  • Sheet is missing actual values currently applied in Main branch, incl Hacker, Lotus and Tanks
  • Sheet is missing distinction for Super Hacker, Super Lotus, Demo Jarmen
  • Sheet value columns have varying widths. It would be better to look at with consistent widths

I suggest to flip the inputs. Allow set patched raw values, and calculate the percentage off of it, and not the other way around.

@xezon xezon mentioned this pull request Sep 6, 2022
Closed
@xezon
Copy link
Collaborator Author

xezon commented Sep 8, 2022

Exile posted new version in Discord.

@xezon xezon merged commit 9095f67 into main Sep 19, 2022
@xezon xezon deleted the add-experience-document branch September 19, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImTimK ImTimK ImTimK approved these changes

Assignees
No one assigned
Labels
Documentation Is documentation or complementary resource
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xezon @ImTimK