Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: China Power Plant Particle Effect Issues And Remove Effects Without Bones #1395

Merged
merged 2 commits into from
Oct 21, 2022

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Oct 19, 2022

1.04

China Power Plant 1 04

  • Overcharging sparks are shown while badly damaged, even when not Overcharging (not visible in image). This also only happens on day maps.
  • Smoke and fire effects at center of building in damaged and badly damaged states due to effects on non-existing bones.
  • Chimney smoke reduced/very white in damaged states. Only happens on day maps and also stops while Overcharging.
  • Chimney fire missing on night maps.
  • Chimney fire missing in badly damaged states. This may be intentional, as another fire breaks out on the small building.

Nuke Power Plant 1 04

  • Nuke variant has no smoke over small chimneys. Bones exist and smoke is shown in portrait art.

Existing bones:

All
    Smoke01/02
    Spark01-07

All D/E
    Smoke06

Nuke _/N/S/NS:
    Smoke03 (thin little chimney)
    Smoke04 (thick little chimney)

Nuke D/DN/DS/DNS:
    Smoke03 (thin little chimney)
*click for script*
import re
from pathlib import Path

files = list(Path(".").glob("*.W3D"))

bones = [
    rb"FIRE\d\d",
    rb"SMOKE\d\d",
    rb"SPARK\d\d",
]

patterns = [re.compile(b) for b in bones]

for file in files:
    print(file)

    with open(file, "rb") as f:
        data = f.read()

    for pattern in patterns:
        for match in pattern.finditer(data):
            start, end = match.span()
            print("\t" + data[start: end].decode())

    print()

patch

  • Overcharge particles only shown when overcharging.
  • No effects emerging from center of building.
  • Big fire in damaged state shown on all maps. Smoke column not reduced on some maps either.
  • No inexplicable differences between normal and Overcharging mode.

@commy2 commy2 added Bug Something is not working right Major Severity: Minor < Major < Critical < Blocker Performance Is a performance concern labels Oct 19, 2022
@commy2 commy2 changed the title - Fix: China Power Plant Particle Effect Issues And Remove Effects Without Bones Oct 19, 2022
@xezon
Copy link
Collaborator

xezon commented Oct 20, 2022

I will test this.

@xezon
Copy link
Collaborator

xezon commented Oct 20, 2022

There are 2 smoke particles on the _E big chimney. They have different look and velocity. I suggest replacing the small smoke with a small fire.

shot_20221020_114001_2

@commy2
Copy link
Collaborator Author

commy2 commented Oct 20, 2022

The fire in D is replaced by a generic smoke column in E. Same bone (position). It is mixed with the steam from the Reactor. Reactor steam already is two particle effects next to each other, presumably for volume. So there're actually three smoke pilars in that chimney in 1.04.

@xezon
Copy link
Collaborator

xezon commented Oct 21, 2022

Looks very nice now. One more improvement I can think of is making one of the big smokes in _D and _E black, so that it looks darker than in undamaged. But we can do that in separate change, as that is not directly related to this change.

shot_20221021_133453_1

shot_20221021_133607_2

@commy2 commy2 merged commit a0324cd into main Oct 21, 2022
@commy2 commy2 deleted the fix-china-power-plant-bones branch October 21, 2022 12:42
@xezon xezon added China Affects China faction Minor Severity: Minor < Major < Critical < Blocker and removed Major Severity: Minor < Major < Critical < Blocker labels Mar 19, 2023
@commy2 commy2 mentioned this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working right China Affects China faction Minor Severity: Minor < Major < Critical < Blocker Performance Is a performance concern
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants