Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Smoke Pillars To Small Chimneys On Nuke General Power Plant #1396

Merged
merged 1 commit into from
Oct 29, 2022

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Oct 19, 2022

1.04

  • Smoke from small chimneys on portrait art, but not on model

patch

  • Smoke on model and portrait

Notes:

Small thick chimney is missing the bone in damaged state. Assume it is "broken" (meaning: the building, not the model). Badly damaged state chimneys are missing or collapsed, so no effects either.

@commy2 commy2 added Design Is a matter of game design Minor Severity: Minor < Major < Critical < Blocker labels Oct 19, 2022
@xezon
Copy link
Collaborator

xezon commented Oct 20, 2022

I will test this.

@xezon
Copy link
Collaborator

xezon commented Oct 20, 2022

I like the sizes and colors. However, the smoke directions do not match. The big reactor smoke has wind simulation pushing it rightwards. The new smoke is flying upwards. They should fly into the same direction. On that note, we may want to tackle this in a separate change if this is broader issue affecting several smokes.

shot_20221020_115025_1

Base automatically changed from fix-china-power-plant-bones to main October 21, 2022 12:42
@xezon
Copy link
Collaborator

xezon commented Oct 22, 2022

Smoke drift addressed with

This change on its own is good as is.

@xezon
Copy link
Collaborator

xezon commented Oct 29, 2022

This change needs merge conflicts resolved.

@commy2 commy2 force-pushed the add-nuke-reactor-chimney-smoke branch from ee6468c to eac1beb Compare October 29, 2022 13:35
@xezon xezon merged commit 34b5b6a into main Oct 29, 2022
@xezon xezon deleted the add-nuke-reactor-chimney-smoke branch October 29, 2022 14:15
@xezon xezon added China Affects China faction Design Is a matter of game design and removed Design Is a matter of game design labels Mar 19, 2023
@commy2 commy2 mentioned this pull request Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
China Affects China faction Design Is a matter of game design Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants