Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Add initial delay to Suicide ability #2303

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Aug 27, 2023

This adds a configurable delay to the Suicide ability from Demogen.

delay.mp4

The goal is to nerf Demo Rebel Ambush vs armies.

@commy2 commy2 added Major Severity: Minor < Major < Critical < Blocker Nerf Makes a thing less powerful GLA Affects GLA faction labels Aug 27, 2023
@commy2 commy2 force-pushed the change-initial-delay-suicide branch from 58eba5c to 3e32820 Compare August 27, 2023 16:28
@commy2 commy2 force-pushed the change-initial-delay-suicide branch 2 times, most recently from f1b7e43 to 018caa9 Compare August 27, 2023 19:28
@commy2
Copy link
Collaborator Author

commy2 commented Aug 27, 2023

The delay is currently set to 3 seconds.

I tested it with all Demogen units and it works. Second test. I tried putting units in some situations where Suicide fails in 1.04 / is buggy, such as while firing (Technical) or while stuck inside buildings (Rebel). All those issues had been fixed previously. With this change, they do not re-appear. Units behave responsive and suicide when ordered immediately.

This change also has extra logic for the Toxin Tractor that frees up the TERTIARY weapon slot, while keeping the ability to suicide. This freed slot can be used for #1113.

@commy2 commy2 force-pushed the change-initial-delay-suicide branch from 018caa9 to def17e7 Compare August 28, 2023 14:27
@commy2
Copy link
Collaborator Author

commy2 commented Aug 28, 2023

Documentation added. I tested Rebel Ambush specifically, and Rebels now need to wait 3 seconds to be able to explode.

@commy2 commy2 marked this pull request as ready for review August 28, 2023 14:39
@xezon xezon added Design Is a matter of game design Controversial Is controversial labels Aug 28, 2023
@commy2 commy2 force-pushed the change-initial-delay-suicide branch from def17e7 to 2b94664 Compare August 28, 2023 15:06
xezon

This comment was marked as resolved.

@commy2

This comment was marked as resolved.

@xezon

This comment was marked as resolved.

@commy2

This comment was marked as resolved.

@commy2

This comment was marked as resolved.

@commy2

This comment was marked as outdated.

@xezon
Copy link
Collaborator

xezon commented Aug 28, 2023

I got latest and now it works.

I see there is a little glitch with the command set after suicide. After pressing the suicide button, it shows the suicide ability reloading for a short moment before hiding the command set. Any way to avoid that?

@commy2
Copy link
Collaborator Author

commy2 commented Aug 28, 2023

I tried a few things without success. I don't know how that would be possible. Sry.

@xezon
Copy link
Collaborator

xezon commented Aug 28, 2023

Perhaps we can upgrade the command set to an empty one?

@xezon

This comment was marked as resolved.

@commy2

This comment was marked as resolved.

@commy2

This comment was marked as resolved.

@MTKing4
Copy link
Collaborator

MTKing4 commented Aug 29, 2023

Very nice! This hits 7 birds with one stone :D

@MTKing4 MTKing4 self-assigned this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Controversial Is controversial Design Is a matter of game design GLA Affects GLA faction Major Severity: Minor < Major < Critical < Blocker Nerf Makes a thing less powerful
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demo and Toxin GLA Ambush are very strong
3 participants