Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Sentry Drone Lacks Voice Line When Leaving Factory #256

Merged
merged 2 commits into from
Sep 9, 2021

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Sep 9, 2021

ZH 1.04

  • The Sentry Drone is so ashamed of its poor performance, it's the only unit in the game that does not announce itself when constructed.

After patch:

  • beep beep beep boop
  • The sound effect is only played for the player, not for the enemy or allies. It works like every other announcer voice line.

@commy2 commy2 added the Bug Something is not working right label Sep 9, 2021
@xezon xezon self-requested a review September 9, 2021 17:12
Sounds = vsenseld
Control = random
Volume = 80
MinVolume = 70
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you pick these volumes? I am asking because for VoiceCreate sounds of other units I mostly see these values:

  Volume  = 110
  MinVolume = 100

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most units use 90 db for "orders" and 100-110 db for "announcing". The Sentry Drone uses 60 db for orders, so I made creation also 30 db quiter. It's probably a loud sample or something. It feels jarring if the unit is much louder when created compared to when used.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. If you say it sounds proper in game with these values, then its all good.

@xezon xezon self-requested a review September 9, 2021 19:30
@commy2 commy2 merged commit 5c6c674 into main Sep 9, 2021
@commy2 commy2 deleted the fix-sentry-drone-announcer branch September 9, 2021 19:31
@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Audio Is audio related USA Affects USA faction labels Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Audio Is audio related Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker USA Affects USA faction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants