Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Sentry Drone Lacks Voice Line When Leaving Factory #256

Merged
merged 2 commits into from
Sep 9, 2021
Merged

Fix: Sentry Drone Lacks Voice Line When Leaving Factory #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24a9837
Fix: Sentry Drone Lacks Voice Line When Leaving Factory
commy2 Sep 9, 2021
167b4f1
Merge branch 'main' into fix-sentry-drone-announcer
commy2 Sep 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Patch104pZH/Design/Tasks/commy2_tasks.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ https://github.com/commy2/zerohour/issues/227 [DONE][NPROJECT] Toxin Truc
https://github.com/commy2/zerohour/issues/226 [DONE][NPROJECT] Propaganda Center And Bunker Use Default Radar Priority
https://github.com/commy2/zerohour/issues/225 [DONE][NPROJECT] Spectre Loses Team Color When Shot Down
https://github.com/commy2/zerohour/issues/224 [DONE][NPROJECT] Mixing Battle Masters From Different Sub-Factions Does Not Grant Horde Bonus
https://github.com/commy2/zerohour/issues/223 [IMPROVEMENT][NPROJECT] Sentry Drone Lacks Voice Line When Leaving Factory
https://github.com/commy2/zerohour/issues/223 [DONE][NPROJECT] Sentry Drone Lacks Voice Line When Leaving Factory
https://github.com/commy2/zerohour/issues/222 [MAYBE] Poison Fields Can Clear Poison Fields
https://github.com/commy2/zerohour/issues/221 [IMPROVEMENT][NPROJECT] Units Sometimes Waste Shots On Overlord Debris
https://github.com/commy2/zerohour/issues/220 [DONE][NPROJECT] Units Sometimes Waste Shots On Poisoned Or Burned Infantry
Expand Down
3 changes: 2 additions & 1 deletion Patch104pZH/GameFilesEdited/Data/INI/Object/AirforceGeneral.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6791,6 +6791,7 @@ Object AirF_AmericaVehicleSentryDrone
CommandSet = AmericaVehicleSentryDroneCommandSet

; Patch104p @bugfix commy2 04/09/2021 Added missing move start sound effects from vanilla USA Sentry Drone.
; Patch104p @bugfix commy2 09/09/2021 Added missing sound when unit leaves factory.

; *** AUDIO Parameters ***
VoiceSelect = SentryDroneVoiceSelect
Expand All @@ -6801,7 +6802,7 @@ Object AirF_AmericaVehicleSentryDrone
SoundMoveStartDamaged = SentryDroneMoveStart
UnitSpecificSounds
; These have the syntax of SomeNameSomewhereInCode = SomeNameSomewhereInLookupINIs
VoiceCreate = NoSound
VoiceCreate = SentryDroneVoiceCreate
TurretMoveStart = NoSound
TurretMoveLoop = NoSound
VoiceEnter = NoSound
Expand Down
3 changes: 2 additions & 1 deletion Patch104pZH/GameFilesEdited/Data/INI/Object/AmericaVehicle.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2158,6 +2158,7 @@ Object AmericaVehicleSentryDrone
CommandSet = AmericaVehicleSentryDroneCommandSet

; Patch104p @bugfix commy2 04/09/2021 Added missing move start sound effects when damaged.
; Patch104p @bugfix commy2 09/09/2021 Added missing sound when unit leaves factory.

; *** AUDIO Parameters ***
VoiceSelect = SentryDroneVoiceSelect
Expand All @@ -2168,7 +2169,7 @@ Object AmericaVehicleSentryDrone
SoundMoveStartDamaged = SentryDroneMoveStart
UnitSpecificSounds
; These have the syntax of SomeNameSomewhereInCode = SomeNameSomewhereInLookupINIs
VoiceCreate = NoSound
VoiceCreate = SentryDroneVoiceCreate
TurretMoveStart = NoSound
TurretMoveLoop = NoSound
VoiceEnter = NoSound
Expand Down
3 changes: 2 additions & 1 deletion Patch104pZH/GameFilesEdited/Data/INI/Object/BossGeneral.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19718,6 +19718,7 @@ Object Boss_VehicleSentryDrone
CommandSet = AmericaVehicleSentryDroneCommandSet

; Patch104p @bugfix commy2 04/09/2021 Added missing move start sound effects from vanilla USA Sentry Drone.
; Patch104p @bugfix commy2 09/09/2021 Added missing sound when unit leaves factory.

; *** AUDIO Parameters ***
VoiceSelect = SentryDroneVoiceSelect
Expand All @@ -19728,7 +19729,7 @@ Object Boss_VehicleSentryDrone
SoundMoveStartDamaged = SentryDroneMoveStart
UnitSpecificSounds
; These have the syntax of SomeNameSomewhereInCode = SomeNameSomewhereInLookupINIs
VoiceCreate = NoSound
VoiceCreate = SentryDroneVoiceCreate
TurretMoveStart = NoSound
TurretMoveLoop = NoSound
VoiceEnter = NoSound
Expand Down
3 changes: 2 additions & 1 deletion Patch104pZH/GameFilesEdited/Data/INI/Object/LaserGeneral.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6511,6 +6511,7 @@ Object Lazr_AmericaVehicleSentryDrone
CommandSet = Lazr_AmericaVehicleSentryDroneCommandSet

; Patch104p @bugfix commy2 04/09/2021 Added missing move start sound effects from vanilla USA Sentry Drone.
; Patch104p @bugfix commy2 09/09/2021 Added missing sound when unit leaves factory.

; *** AUDIO Parameters ***
VoiceSelect = SentryDroneVoiceSelect
Expand All @@ -6521,7 +6522,7 @@ Object Lazr_AmericaVehicleSentryDrone
SoundMoveStartDamaged = SentryDroneMoveStart
UnitSpecificSounds
; These have the syntax of SomeNameSomewhereInCode = SomeNameSomewhereInLookupINIs
VoiceCreate = NoSound
VoiceCreate = SentryDroneVoiceCreate
TurretMoveStart = NoSound
TurretMoveLoop = NoSound
VoiceEnter = NoSound
Expand Down
3 changes: 2 additions & 1 deletion Patch104pZH/GameFilesEdited/Data/INI/Object/SuperWeaponGeneral.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6977,6 +6977,7 @@ Object SupW_AmericaVehicleSentryDrone
CommandSet = AmericaVehicleSentryDroneCommandSet

; Patch104p @bugfix commy2 04/09/2021 Added missing move start sound effects from vanilla USA Sentry Drone.
; Patch104p @bugfix commy2 09/09/2021 Added missing sound when unit leaves factory.

; *** AUDIO Parameters ***
VoiceSelect = SentryDroneVoiceSelect
Expand All @@ -6987,7 +6988,7 @@ Object SupW_AmericaVehicleSentryDrone
SoundMoveStartDamaged = SentryDroneMoveStart
UnitSpecificSounds
; These have the syntax of SomeNameSomewhereInCode = SomeNameSomewhereInLookupINIs
VoiceCreate = NoSound
VoiceCreate = SentryDroneVoiceCreate
TurretMoveStart = NoSound
TurretMoveLoop = NoSound
VoiceEnter = NoSound
Expand Down
11 changes: 11 additions & 0 deletions Patch104pZH/GameFilesEdited/Data/INI/SoundEffects.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6800,6 +6800,17 @@ End
; Type = ui voice player
;End

; Patch104p @bugfix commy2 09/09/2021 Sound used when Sentry Drone leaves factory.

AudioEvent SentryDroneVoiceCreate
Sounds = vsenseld
Control = random
Volume = 80
MinVolume = 70
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you pick these volumes? I am asking because for VoiceCreate sounds of other units I mostly see these values:

  Volume  = 110
  MinVolume = 100

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most units use 90 db for "orders" and 100-110 db for "announcing". The Sentry Drone uses 60 db for orders, so I made creation also 30 db quiter. It's probably a loud sample or something. It feels jarring if the unit is much louder when created compared to when used.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. If you say it sounds proper in game with these values, then its all good.

Priority = high
Type = world global player
End

AudioEvent SentryDroneVoiceSelect
Sounds = vsensela vsenselb vsenselc vsenseld
Control = random
Expand Down