Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Dummy Weapons Cause Notifications And Hit Effects #279

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Fix: Dummy Weapons Cause Notifications And Hit Effects #279

merged 1 commit into from
Sep 10, 2021

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Sep 10, 2021

ZH 1.04:

  • Objects with dummy weapons do a tiny amount of damage that triggers the "we're under attack!" notifications, and cause hit effects (sparks and impact sounds).

After patch:

  • No more notifications or impact effects / sounds by dummy weapons.

Repro (one notorious example):

  • Place a Sneak Attack. Force-fire with the Sneak Attack on a nearby unit.

Note:

@commy2 commy2 added the Bug Something is not working right label Sep 10, 2021
xezon
xezon approved these changes Sep 10, 2021
View reviewed changes
Patch104pZH/GameFilesEdited/Data/INI/Object/System.ini
Mass = 1
End
Behavior = MissileAIUpdate ModuleTag_07
TryToFollowTarget = Yes;;;;;;;;;No
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove the comment.

@commy2 commy2 merged commit 48257be into main Sep 10, 2021
@commy2 commy2 deleted the fix-dummy branch September 10, 2021 19:30
xezon pushed a commit that referenced this pull request Sep 10, 2021
@commy2 @xezon
Fix: Dummy Weapons Cause Notifications And Hit Effects (#279)
82d1943
@commy2 commy2 mentioned this pull request Aug 26, 2022
Merged
xezon pushed a commit that referenced this pull request Aug 28, 2022
@commy2
Fix: Dummy Weapons Cause Notifications And Hit Effects (#279)
12b9fa9
@xezon xezon added the Minor Severity: Minor < Major < Critical < Blocker label Mar 18, 2023
xezon added a commit that referenced this pull request Mar 26, 2023
@xezon
Add ini documentation for pull #279
9d66b9a
@xezon xezon mentioned this pull request Mar 26, 2023
Merged
This was referenced Jun 23, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xezon xezon xezon approved these changes

Assignees
No one assigned
Labels
Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@commy2 @xezon