Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use name The Things Stack Enterprise #850

Merged
merged 1 commit into from Apr 9, 2022
Merged

Conversation

johanstokking
Copy link
Member

Summary

Follow up on https://github.com/TheThingsIndustries/lorawan-stack/pull/3156

Changes

Use The Things Stack Enterprise, almost everywhere via the shortcode. If that isn't possible, because it's a literal block, spell it out.

Notes for Reviewers

The AMI CFT parameter InstanceName that defaults to the-things-enterprise-stack cannot be changed as it would trigger a resource replacement in AWS. This is already reflected in lorawan-stack-aws repo.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Run Locally: Verified that the docs build using make server, posted screenshots, verified external links. Test with HUGO_PARAMS_SEARCH_ENABLED=true if style changes will affect the search bar.
  • New Features Marked: Documentation for new features is marked using the new-in-version shortcode, according to the guidelines in CONTRIBUTING.
  • Style Guidelines: Documentation obeys style guidelines in CONTRIBUTING.
  • Commits: Commit messages follow guidelines in CONTRIBUTING, there are no fixup commits left.

Copy link
Contributor

@htdvisser htdvisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops I was too quick. The shortcodes are missing the second closing brace.

@johanstokking johanstokking merged commit c44467b into master Apr 9, 2022
@johanstokking johanstokking deleted the fix/ttse-naming branch April 9, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants