-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MACSettings.DesiredMaxEIRP field #4128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really don't know much about how these custom wrappers work, so maybe good to wait for review from @rvolosatovs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to add.
afd2dac
to
61b2092
Compare
61b2092
to
2952751
Compare
Summary
Closes #4090
Changes
DeviceEIRPValue
struct (containing an enum value of typeDeviceEIRP
)MACSettings.DesiredMaxEirp
field.mac.DeviceDesiredMaxEIRP
Testing
desired_max_eirp
field from the CLI and verify that theDesiredParameters.MaxEIRP
value is set properly after device joins.Regressions
There should not be any, the default value for the new setting is
nil
which preserves the old behaviour.Notes for Reviewers
DesiredMaxEirp
instead ofDesiredMaxEIRP
.FieldIsZero()
parts probably need a review from @rvolosatovs to make sure that I did not miss anything.Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.