Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print Double (Service No. 3) #66

Closed
colbac8 opened this issue Dec 11, 2019 · 5 comments
Closed

Print Double (Service No. 3) #66

colbac8 opened this issue Dec 11, 2019 · 5 comments

Comments

@colbac8
Copy link

colbac8 commented Dec 11, 2019

Hi, I'm using the latest version of RARS 1.4 for testing the double extension. I noticed that the print service number 3 (print double) is not implemented. How I can print out a double?

@TheThirdOne
Copy link
Owner

As it stands there isn't a print double system call. I neglected to add it when implementing the double extension. The system call documentation correctly shows that system call 3 (printDouble) and 7 (readDouble) are both unavailable.

A printf implementation compiled to assembly should work if your goal is making it work with version 1.4

Otherwise, I'll put implementing those system calls on my TODO list. It should be pretty easy to add if someone else wants to jump in though.

@colbac8
Copy link
Author

colbac8 commented Dec 11, 2019

ok, thank you. Thank you for the printf hint, I'll test it.

@TheThirdOne
Copy link
Owner

e835ec5 removed a bunch of double related system calls. Probably all of them can be moved into the current codebase with minor modifications. I would accept a PR for any subset of these calls updated.

The calls as they existed prior to e835ec5:

TheThirdOne added a commit that referenced this issue Apr 21, 2020
Note this does not currently compile, but it serves as a
base to show what changes were needed and make it clear if
issue were introduced in updating or if they already existed.

This is the base for a fix to #66
@TheThirdOne
Copy link
Owner

Those five system calls are now available in the continuous release. I haven't tested them much, but they seem to be working.

Let me know if they aren't working right.

@Jonas-Salcedo
Copy link

Jonas-Salcedo commented Apr 21, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants