feat(android): add prop to control debug log level #3277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 5, 2023 22:56
…native-video into chore/add_custom_log_level_configuration # Conflicts: # Video.js
…native-video into chore/add_custom_log_level_configuration
freeboub
changed the title
freeboub
changed the title
…native-video into chore/add_custom_log_level_configuration
| val key = iterator.nextKey() | ||
| result[key] = readableMap.getString(key) | ||
| } | ||
| return result |
There was a problem hiding this comment.
Is this same as this ?
https://github.com/react-native-video/react-native-video/blob/abdf3988a9173924ba8007003c007b633a2c44f6/android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerViewManager.java#L449C5-L464C6
If yes, do we need the old one ?
There was a problem hiding this comment.
Thank you, I will remove the old one !
added 2 commits
October 9, 2023 22:29
…native-video into chore/add_custom_log_level_configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add custom log level prop for android.
It allows to increase log verbosity on demand.
This is a preliminary PR for futur work.
A toolbox to handle safe parsing of component props has also be created (more job to do to apply it systematically).
Documentation updated.