Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): notification controls enabled by default #3861

Merged
merged 1 commit into from
May 31, 2024
Merged

fix(ios): notification controls enabled by default #3861

merged 1 commit into from
May 31, 2024

Conversation

KrzysztofMoch
Copy link
Collaborator

Summary

Fix notification controls enabled by default

Motivation

fixes #3856

Changes

  • Check if showNotificationControls is true

Test plan

  • set showNotificationControls to false
  • build on real device
  • notification controls should not be visible

@KrzysztofMoch KrzysztofMoch changed the title fix(ios): fix notification controls enabled by default fix(ios): notification controls enabled by default May 30, 2024
@KrzysztofMoch KrzysztofMoch mentioned this pull request May 30, 2024
Closed
@freeboub freeboub merged commit 5c6dfb2 into TheWidlarzGroup:master May 31, 2024
6 checks passed
@KrzysztofMoch KrzysztofMoch deleted the fix/ios-notification-controls branch June 7, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freeboub freeboub freeboub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: showNotificationControls is visible on iOS even when it is set to false
2 participants
@KrzysztofMoch @freeboub