Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skin selector modal stays when you swipe to a different category #135

Closed
ManuViola77 opened this issue May 11, 2023 · 2 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@ManuViola77
Copy link

ManuViola77 commented May 11, 2023

Describe the bug
If you have opened the skin selector modal and you swipe to another category, the skin selector modal doesn't close and it leaves inconsistent since is not above the correct emoji anymore.

To Reproduce
Steps to reproduce the behavior:

  1. Open the EmojiPicker with params including enableSearchBar and categoryPosition="bottom"
  2. Long tap to see the skin of one of the emojis
  3. Swipe to the right to the next category
  4. See that the skin selector modal still appears in the new category

Expected behavior
When I swipe to a different category the skin selector modal should hide since Im no longer seeing the emoji that is associated with it.

Screenshots
image

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • It was reproducible in lots of devices both iOS and Android both simulator and real device.
  • "rn-emoji-keyboard": "^1.2.1" -> version we have for this library
  • "react-native": "0.71.4" -> react native version
  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
To fix this I added in the component EmojiStaticKeyboard, in the handleScroll function, I now call the clearEmojiTonesData() function to hide the skin tones modal.

@ManuViola77 ManuViola77 added the bug Something isn't working label May 11, 2023
@mateki0 mateki0 self-assigned this May 17, 2023
@mateki0
Copy link
Contributor

mateki0 commented May 17, 2023

Hey, as for the other bug report we really appreciate your report. Maybe in the future you will open a PR with a fix? It's always nice to have a contribution to an OpenSource :)

@jakex7
Copy link
Member

jakex7 commented Jun 18, 2023

Hi @ManuViola77, thanks for reporting this issue.
@mateki0's fix has been merged and released in version 1.3.0.

I'm closing this issue as solved, but If it's still valid, feel free to reopen 😃

@jakex7 jakex7 closed this as completed Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants