Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: emoji tones bugs #137

Merged
merged 3 commits into from
Jun 18, 2023
Merged

fix: emoji tones bugs #137

merged 3 commits into from
Jun 18, 2023

Conversation

mateki0
Copy link
Contributor

@mateki0 mateki0 commented May 17, 2023

Fixed:

  1. Skin Selector Modal can have wrong Y offset #134
  2. Skin selector modal stays when you swipe to a different category #135
  3. Problem on some devices with wrong category highlited (Samsung and Iphone were fine, but it's visible on my Xiaomi mi 10t lite). This if (Number.isInteger(index)) setActiveCategoryIndex(index) was always falsy. See video and SS.
Screenshot 2023-05-17 at 09 44 20
20230517_093843.mp4

@mateki0 mateki0 requested a review from jakex7 May 17, 2023 07:44
jakex7
jakex7 approved these changes Jun 18, 2023
View reviewed changes
Copy link
Member

@jakex7 jakex7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jakex7
Copy link
Member

jakex7 commented Jun 18, 2023

I've resolved conflict with master

@jakex7 jakex7 merged commit bfb10ec into master Jun 18, 2023
3 checks passed
@jakex7 jakex7 deleted the fix/emoji-tones-bugs branch June 18, 2023 09:01
@jakex7 jakex7 changed the title Fix/emoji tones bugs fix: emoji tones bugs Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManuViola77 ManuViola77 ManuViola77 approved these changes

@jakex7 jakex7 jakex7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mateki0 @jakex7 @ManuViola77