theano.tensor.constant reshape fix

[SinaHonari]

fixes issue #3031

[bouthilx]

I was wrong, I verified and as_tensor_variable(()).ndim == 1. You don't need to modify this.

[bouthilx]

@SinaHonari
Thanks for the quick PR!

You still need to add a test case to ensure this bug does not happen again. Add a new method test_empty_shp() at the end of this class

[SinaHonari]

Boss your comments and concerns are all realized :)

[bouthilx]

Thanks Sina! But you forgot about the unit-test. ;)

[SinaHonari]

What should the unit test do?

[bouthilx]

Test the basic case reported and make sure it doesn't fail. #3031

theano.tensor.constant([1]).reshape(())

As I said above

You still need to add a test case to ensure this bug does not happen again. Add a new method test_empty_shp() at the end of this class.

Should be quite simple. :)

[SinaHonari]

You can check if the test is sufficient.

[bouthilx]

Please compile the function and verify that output.shape == ()
That will be sufficient. :)

[bouthilx]

Looks good to me, Thanks Sina!