Update library/extensions/comments-extensions.php #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed type="text" to type="email" for the email input. Changed type="text" to type="url" for the web address. These HTML5 attributes are 100% backwards compatible and revert to type="text" for older browsers which ignore these input types. Some info on the types here: http://diveintohtml5.info/forms.html
|
Yes, I am aware of the fact that these form elements degrade gracefully. And it is a easy thing to add this for better ios experience. That said, we are focusing on the translation strings for the upcoming 1.0.3 release. The question of adding html5 elements to thematic is still an open discussion and no decision has been made yet. I will hold off on merging until a future release. You can filter |
|
@middlesister I'm ok with your merging this for the upcoming release |
middlesister
added a commit
that referenced
this pull request
Jan 10, 2013
Update library/extensions/comments-extensions.php
|
Done. Thanks @coliff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed type="text" to type="email" for the email input.
Changed type="text" to type="url" for the web address.
These HTML5 attributes are 100% backwards compatible and revert to type="text" for older browsers which ignore these input types. For modern browsers, the input types can be helpful such as validating email address before submitting and custom keyboard types on iOS devices.
Some info on the types here: http://diveintohtml5.info/forms.html