-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/swap html5 elements #67
Conversation
Add legacy filter to use <div> tags
Add legacy filter to use <div> tags in xhtml mode
Add legacy filters for using <div> tags and opening/closing <ul> list
Add legacy filters to use <li> elements in xhtml mode
Add legacy filters to use <h3> elements in xhtml mode
Add legacy filter to use <div> tags in xhtml mode
Add legacy override for <div> tag in xhtml mode
Add legacy override for <div> tag in xhtml mode
Add css class .entry-header to <header> Add legacy filter to remove the <header> tag in xhtml mode
Add legacy filter to use <div> tags in xhtml mode
Add legacy filter for using h2 where appropriate in xhtml mode
Add legacy filter to use <div> tags in xhtml mode
Add legacy functions for using <div> tags in xhtml mode
@emhr This is basically a complete port of my html5 plugin. The only thing not added is a str_replace on wp_page_menu to use the Still not swapped are some loops that are directly in template files, namely The Links page is getting deprecated (right?), but the others need to be addressed. The reason I didn't swap them yet is because I need to solve how to do the legacy mode. We could simply move these too into content-extensions.php, and treat them the same as the others. Also missing are unit tests for the childtheme_override_* functions. I have to figure out how to test those. Otherwise I think the html5 elements are there. |
Use get_echo where appropriate and let the filters work on their own.
Tests for childtheme overrides are now in a separate group and can be run using a command line parameter.
Legacy mode is also a separate group and is run with
And the rest is in group default
|
A possible solution for the template files is to include them in the legacy folder and then swap them in via the
Of course with added checks if child theme has defined the files etc, but as a general principle. cc @emhr |
Changed in attachment.php, links.php, page.php, template-page-archive.php and template-page-fullwidth.php
Add legacy template files to the /legacy/directory
Feature/swap html5 elements
Legacy template files are now loaded in legacy mode. Merging this. |
No description provided.