new api for kits #1976
Merged
new api for kits #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GunkaArtur
force-pushed
the
25518-newApiKits
branch
4 times, most recently
from
b28b963
to
3514eea
Compare
GunkaArtur
force-pushed
the
25518-newApiKits
branch
4 times, most recently
from
f306885
to
b25e25a
Compare
GunkaArtur
force-pushed
the
25518-newApiKits
branch
2 times, most recently
from
609b99b
to
44f06b8
Compare
GunkaArtur
force-pushed
the
25518-newApiKits
branch
2 times, most recently
from
b58f709
to
c3b1e5e
Compare
victor-pg
requested changes
Apr 25, 2024
| }; | ||
| }; | ||
|
|
||
| export const getKitData = async (url: string, kitId: string, id: string) => { |
There was a problem hiding this comment.
same changes as here: https://github.com/bagrinsergiu/blox-editor/pull/25545#pullrequestreview-2021434916
| return allElements; | ||
| }; | ||
| export function convertToCategories(obj: Record<string, string>): Categories[] { | ||
| return Object.entries(obj).map(([_, title]) => ({ |
There was a problem hiding this comment.
use Object.values instead of Object.entries
GunkaArtur
force-pushed
the
25518-newApiKits
branch
2 times, most recently
from
531a25d
to
b5bd1fe
Compare
GunkaArtur
force-pushed
the
25518-newApiKits
branch
3 times, most recently
from
56515d8
to
8629047
Compare
GunkaArtur
force-pushed
the
25518-newApiKits
branch
2 times, most recently
from
d6dcc62
to
b9fcdf6
Compare
GunkaArtur
force-pushed
the
25518-newApiKits
branch
3 times, most recently
from
9eb7ef9
to
e5943cb
Compare
GunkaArtur
force-pushed
the
25518-newApiKits
branch
from
fc9e05c
to
15eb092
Compare
GunkaArtur
force-pushed
the
25518-newApiKits
branch
from
1db3f06
to
222f9a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue https://github.com/bagrinsergiu/blox-editor/issues/25518