Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels in Taxonomy #1347

Closed
andreiglingeanu opened this issue Mar 9, 2016 · 9 comments
Closed

Labels in Taxonomy #1347

andreiglingeanu opened this issue Mar 9, 2016 · 9 comments

Comments

@andreiglingeanu
Copy link
Collaborator

When I add options for any taxonomy in options/taxonomies/*.php it handles labels in a strange way.

It only displays labels correctly options of the first level.

I understand that you are limited by the fact that WordPress used to implement this whole columns thing with tables. This also doesn't allow us to add tabs to the taxonomies page. I know that this is specified in the manual as a restriction.

Have you tried to include a div below this table, just like you do for posts -- including them below the wp editor? This may require to disable lazy tabs for this particular container, not sure. This will fix a lot of troubles and will bypass restriction you wrote into the manual.

I haven't looked into the code yet, let me know if there's some limitations that would not let us do this.

@danyj
Copy link
Contributor

danyj commented Mar 9, 2016

@moldcraft lifted the restrictions few days ago but I think the manual is not up to date for now
#1295 (comment)

@ghost
Copy link

ghost commented Mar 9, 2016

Have you tried to include a div below this table, just like you do for posts -- including them below the wp editor?

If you'll find a WordPress action to do that we will do it.

I think the manual is not up to date for now

Yes, because the changes are not included in release yet.

@ghost ghost self-assigned this Mar 9, 2016
@ghost ghost closed this as completed Mar 10, 2016
@andreiglingeanu
Copy link
Collaborator Author

@moldcraft

If you'll find a WordPress action to do that we will do it.

There you go. You can also find a whole range of deprecated ones.

As you can see, it requires you to add one action per taxonomy. We'll have to loop through every taxonomy using get_taxonomies, or something like that.

@ghost ghost reopened this Mar 10, 2016
@ghost ghost added the ready label Mar 10, 2016
@andreiglingeanu
Copy link
Collaborator Author

@moldcraft Thanks.

@ghost
Copy link

ghost commented Mar 10, 2016

I will use get_current_screen() to detect current taxonomy and do only one add_action()

@andreiglingeanu
Copy link
Collaborator Author

@moldcraft Sounds great.

@ghost
Copy link

ghost commented Mar 10, 2016

I think initially we added options in table to make them look the same as WordPress options, to not "break" the design.

@andreiglingeanu
Copy link
Collaborator Author

I see, that was a good temporary behavior. It breaks as soon as you add a nested option or when you need tabs or other containers.

@ghost ghost added in progress and removed ready labels Mar 10, 2016
@ghost ghost closed this as completed in 610311f Mar 10, 2016
@ghost ghost removed the in progress label Mar 10, 2016
@ghost
Copy link

ghost commented Mar 10, 2016

The commit contains some hardcode css fixes. I don't know a general solution. If you'll find one, please pull request.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants