Fixing a library issue and created a parser template #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @naveci thanks for opening another PR, would you be able to update the template with specifically what these changes do? I'll be able to create a corresponding case to track the features then. Cheers! |
|
Updated the description. |
TheresAFewConors
added
Bug Fix
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a problem in reference to some packages used.
Also introduced a github workflow (linting_check.yaml) that will lint the code after submitting it to github. This way, there should be more alerts triggered to syntax issues or problems with referring to packages.
Does this fix a known existing bug under Issues?
Nothing mentioned under issues currently. However, bug can happen with the following functions:
urlDecoder
safelinksDecoder
phishingMenu
emailTemplateGen
This is most likely a result from messing with the packages by several PRs (including my own when it comes to tkinter).
Linting this correctly reveals the error. Hence why this PR also includes the workflow.
Type of Change
Please delete any options that do not apply here:
Any further info related to the addition